restore bluetooth socket constants on Linux #15209
Open
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
dlech
reviewed
Jan 2, 2026
|
|
||
| if sys.platform != "linux": | ||
| __all__ += ["AF_LINK"] | ||
| if sys.platform != "darwin" and sys.platform != "linux": |
There was a problem hiding this comment.
Suggested change
| if sys.platform != "darwin" and sys.platform != "linux": | |
| if sys.platform != "darwin": |
srittau
requested changes
Jan 15, 2026
Comment on lines
+31
to
+37
| _?socket.AF_BLUETOOTH | ||
| _?socket.BDADDR_ANY | ||
| _?socket.BDADDR_LOCAL | ||
| _?socket.BTPROTO_HCI | ||
| _?socket.BTPROTO_L2CAP | ||
| _?socket.BTPROTO_RFCOMM | ||
| _?socket.BTPROTO_SCO |
Collaborator
There was a problem hiding this comment.
We should probably make these entries optional, in case the GitHub runners change and to help with running stubtest locally in different environments.
Suggested change
| _?socket.AF_BLUETOOTH | |
| _?socket.BDADDR_ANY | |
| _?socket.BDADDR_LOCAL | |
| _?socket.BTPROTO_HCI | |
| _?socket.BTPROTO_L2CAP | |
| _?socket.BTPROTO_RFCOMM | |
| _?socket.BTPROTO_SCO | |
| (_?socket\.AF_BLUETOOTH)? | |
| (_?socket\.BDADDR_ANY)? | |
| (_?socket\.BDADDR_LOCAL)? | |
| (_?socket\.BTPROTO_HCI)? | |
| (_?socket\.BTPROTO_L2CAP)? | |
| (_?socket\.BTPROTO_RFCOMM)? | |
| (_?socket\.BTPROTO_SCO)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15207
_socket.pyiconstants are ordered based on the CPython documentation, but that doesn't seem to be the case insocket.pyi. I could merge the newif sys.platform != "darwin":blocks into existingif sys.platform != "darwin":blocks there, but I decided not to because the whole file really could use some re-organization in that regard.If it's amenable, I could apply the same systematic ordering that I did for
os.__all__in #13052 to the blocks insocket.pyiresponsible for import statements and__all__.